Commit 2db6d06c authored by thorben_nehls's avatar thorben_nehls
Browse files

Fix deprecated warning for "paginate/Paginator", flake8 amendments.

parent afe0cf09
[flake8] [flake8]
ignore = E731,W503 ignore = E731,W503
max-line-length = 120 max-line-length = 120
exclude = migrations exclude = migrations,.tox
...@@ -15,5 +15,6 @@ def run(): ...@@ -15,5 +15,6 @@ def run():
shutil.rmtree(STATIC_ROOT, ignore_errors=True) shutil.rmtree(STATIC_ROOT, ignore_errors=True)
shutil.rmtree(MEDIA_ROOT, ignore_errors=True) shutil.rmtree(MEDIA_ROOT, ignore_errors=True)
if __name__ == '__main__': if __name__ == '__main__':
run() run()
from tests.app.settings import * from tests.app.settings import * # noqa: F401,F403
DATABASES = { DATABASES = {
'default': { 'default': {
......
...@@ -6,7 +6,7 @@ Install wagtailvideos using setuptools ...@@ -6,7 +6,7 @@ Install wagtailvideos using setuptools
with open('README.rst', 'r') as f: with open('README.rst', 'r') as f:
readme = f.read() readme = f.read()
from setuptools import find_packages, setup from setuptools import find_packages, setup # noqa: E4
setup( setup(
name='wagtailvideos', name='wagtailvideos',
......
from django.shortcuts import get_object_or_404, render from django.shortcuts import get_object_or_404, render
from django.urls import reverse from django.urls import reverse
from django.core.paginator import Paginator
from wagtail.admin.forms.search import SearchForm from wagtail.admin.forms.search import SearchForm
from wagtail.admin.modal_workflow import render_modal_workflow from wagtail.admin.modal_workflow import render_modal_workflow
from wagtail.admin.utils import PermissionPolicyChecker, popular_tags_for_model from wagtail.admin.utils import PermissionPolicyChecker, popular_tags_for_model
from wagtail.core.models import Collection from wagtail.core.models import Collection
from wagtail.images.views.chooser import get_chooser_js_data from wagtail.images.views.chooser import get_chooser_js_data
from wagtail.search import index as search_index from wagtail.search import index as search_index
from wagtail.utils.pagination import paginate # from wagtail.utils.pagination import paginate
from wagtailvideos.forms import get_video_form from wagtailvideos.forms import get_video_form
from wagtailvideos.models import Video from wagtailvideos.models import Video
...@@ -62,10 +64,12 @@ def chooser(request): ...@@ -62,10 +64,12 @@ def chooser(request):
videos = videos.filter(tags__name=tag_name) videos = videos.filter(tags__name=tag_name)
# Pagination # Pagination
paginator, videos = paginate(request, videos, per_page=12) # paginator, videos = paginate(request, videos, per_page=12)
paginator = Paginator(videos, per_page=12)
page = paginator.get_page(request.GET.get('p'))
return render(request, "wagtailvideos/chooser/results.html", { return render(request, "wagtailvideos/chooser/results.html", {
'videos': videos, 'videos': page,
'is_searching': is_searching, 'is_searching': is_searching,
'query_string': q, 'query_string': q,
}) })
...@@ -76,10 +80,12 @@ def chooser(request): ...@@ -76,10 +80,12 @@ def chooser(request):
if len(collections) < 2: if len(collections) < 2:
collections = None collections = None
paginator, videos = paginate(request, videos, per_page=12) # paginator, videos = paginate(request, videos, per_page=12)
paginator = Paginator(videos, per_page=12)
page = paginator.get_page(request.GET.get('p'))
return render_modal_workflow(request, 'wagtailvideos/chooser/chooser.html', None, { return render_modal_workflow(request, 'wagtailvideos/chooser/chooser.html', None, {
'videos': videos, 'videos': page,
'uploadform': uploadform, 'uploadform': uploadform,
'searchform': searchform, 'searchform': searchform,
'is_searching': False, 'is_searching': False,
...@@ -126,10 +132,12 @@ def chooser_upload(request): ...@@ -126,10 +132,12 @@ def chooser_upload(request):
form = VideoForm() form = VideoForm()
videos = Video.objects.order_by('title') videos = Video.objects.order_by('title')
paginator, videos = paginate(request, videos, per_page=12) # paginator, videos = paginate(request, videos, per_page=12)
paginator = Paginator(videos, per_page=12)
page = paginator.get_page(request.GET.get('p'))
return render_modal_workflow( return render_modal_workflow(
request, 'wagtailvideos/chooser/chooser.html', None, request, 'wagtailvideos/chooser/chooser.html', None,
template_vars={'videos': videos, 'uploadform': form, 'searchform': searchform}, template_vars={'videos': page, 'uploadform': form, 'searchform': searchform},
json_data=get_chooser_js_data() json_data=get_chooser_js_data()
) )
...@@ -3,12 +3,14 @@ from django.shortcuts import get_object_or_404, redirect, render ...@@ -3,12 +3,14 @@ from django.shortcuts import get_object_or_404, redirect, render
from django.urls import reverse from django.urls import reverse
from django.utils.translation import ugettext as _ from django.utils.translation import ugettext as _
from django.views.decorators.vary import vary_on_headers from django.views.decorators.vary import vary_on_headers
from django.core.paginator import Paginator
from wagtail.admin import messages from wagtail.admin import messages
from wagtail.admin.forms.search import SearchForm from wagtail.admin.forms.search import SearchForm
from wagtail.admin.utils import PermissionPolicyChecker, popular_tags_for_model from wagtail.admin.utils import PermissionPolicyChecker, popular_tags_for_model
from wagtail.core.models import Collection from wagtail.core.models import Collection
from wagtail.search.backends import get_search_backends from wagtail.search.backends import get_search_backends
from wagtail.utils.pagination import paginate # from wagtail.utils.pagination import paginate
from wagtailvideos import ffmpeg from wagtailvideos import ffmpeg
from wagtailvideos.forms import VideoTranscodeAdminForm, get_video_form from wagtailvideos.forms import VideoTranscodeAdminForm, get_video_form
...@@ -45,19 +47,21 @@ def index(request): ...@@ -45,19 +47,21 @@ def index(request):
except (ValueError, Collection.DoesNotExist): except (ValueError, Collection.DoesNotExist):
pass pass
paginator, videos = paginate(request, videos) # paginator, videos = paginate(request, videos)
paginator = Paginator(videos, per_page=25)
page = paginator.get_page(request.GET.get('p'))
# Create response # Create response
if request.is_ajax(): if request.is_ajax():
response = render(request, 'wagtailvideos/videos/results.html', { response = render(request, 'wagtailvideos/videos/results.html', {
'vidoes': videos, 'videos': page,
'query_string': query_string, 'query_string': query_string,
'is_searching': bool(query_string), 'is_searching': bool(query_string),
}) })
return response return response
else: else:
response = render(request, 'wagtailvideos/videos/index.html', { response = render(request, 'wagtailvideos/videos/index.html', {
'videos': videos, 'videos': page,
'query_string': query_string, 'query_string': query_string,
'is_searching': bool(query_string), 'is_searching': bool(query_string),
...@@ -180,9 +184,11 @@ def add(request): ...@@ -180,9 +184,11 @@ def add(request):
def usage(request, image_id): def usage(request, image_id):
image = get_object_or_404(Video, id=image_id) image = get_object_or_404(Video, id=image_id)
paginator, used_by = paginate(request, image.get_usage()) # paginator, used_by = paginate(request, image.get_usage())
paginator = Paginator(image.get_usage(), per_page=12)
page = paginator.get_page(request.GET.get('p'))
return render(request, "wagtailvideos/videos/usage.html", { return render(request, "wagtailvideos/videos/usage.html", {
'image': image, 'image': image,
'used_by': used_by 'used_by': page
}) })
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment